SubtreeCache: Use log tile funcs directly #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2398 +/- ##
==========================================
- Coverage 65.78% 65.76% -0.03%
==========================================
Files 107 107
Lines 7749 7743 -6
==========================================
- Hits 5098 5092 -6
Misses 2119 2119
Partials 532 532
Continue to review full report at Codecov.
|
pav-kv
force-pushed
the
subtree_cache_no_more
branch
from
03205f4
to
8d0bd48
Compare
pav-kv
force-pushed
the
subtree_cache_no_more
branch
from
8d0bd48
to
5703118
Compare
pav-kv
changed the title
|
I recommend reviewing commit-by-commit, with "Hide whitespace changes" enabled. |
pav-kv
changed the title
pphaneuf
approved these changes
Mar 12, 2021
| @@ -14,10 +14,7 @@ | |||
|
|
|||
| package storage | |||
|
|
|||
| import ( | |||
| "github.com/google/trillian/storage/storagepb" | |||
| "github.com/google/trillian/storage/tree" | |||
There was a problem hiding this comment.
This builds without tree being imported?
There was a problem hiding this comment.
Look 2 lines below :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the
SubtreeCacheuse log tile population functions directly,as it no longer needs to be log/map polymorphic.
#2378